[wp-trac] [WordPress Trac] #46910: Allow wp_die to called after html has started output

WordPress Trac noreply at wordpress.org
Sun Apr 21 10:46:03 UTC 2019


#46910: Allow wp_die to called after html has started output
----------------------------------+-----------------------------
 Reporter:  spacedmonkey          |       Owner:  SergeyBiryukov
     Type:  defect (bug)          |      Status:  accepted
 Priority:  normal                |   Milestone:  5.2
Component:  Bootstrap/Load        |     Version:  trunk
 Severity:  normal                |  Resolution:
 Keywords:  servehappy has-patch  |     Focuses:
----------------------------------+-----------------------------
Changes (by spacedmonkey):

 * keywords:  needs-patch servehappy => servehappy has-patch


Comment:

 Uploaded the first patch
 [https://core.trac.wordpress.org/attachment/ticket/46910/46910.diff
 46910.diff] as a talking point.

 This is a very simple patch, that just makes sure that html / body tags
 are not re-opened on the front end. All it does it makes you an unstyle
 div with the error message is displayed on the page. Personally, I think
 this is what the end patch should look like. I don't like the idea of
 trying to build a dialog that works on every theme ever write. I think we
 should just output a div with an id, and leave it up the theme creates to
 style it (if they so wish), in a way that fits in with the styling of the
 theme.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/46910#comment:8>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list