[wp-trac] [WordPress Trac] #46923: $wpdb->get_var() — empty sting becomes a NULL

[WordPress Trac]

#46923: $wpdb->get_var() — empty sting becomes a NULL
--------------------------+-----------------------------
 Reporter:  Tkama         |      Owner:  (none)
     Type:  defect (bug)  |     Status:  new
 Priority:  normal        |  Milestone:  Awaiting Review
Component:  General       |    Version:  5.1.1
 Severity:  normal        |   Keywords:
  Focuses:                |
--------------------------+-----------------------------
 Because of the following condition, we get `NULL`, even if a real field
 value is an empty string!

 {{{#!php
 <?php
 return ( isset( $values[ $x ] ) && $values[ $x ] !== '' ) ? $values[ $x ]
 : null;
 }}}

 [See `wp-db.php` Line 2477](https://wp-kama.ru/filecode/wp-includes/wp-
 db.php#L2460-2478)

 I think it is better to delete `$values[ $x ] !== ''` check and return
 field value as it is if it exists - what is usually meant by NULL in PHP
 (empty string is not null!).

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/46923>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform