[wp-trac] [WordPress Trac] #46707: Site health: notify the user while gathering site data

[WordPress Trac]

#46707: Site health: notify the user while gathering site data
-------------------------------------------------+-------------------------
 Reporter:  azaozz                               |       Owner:  (none)
     Type:  defect (bug)                         |      Status:  new
 Priority:  normal                               |   Milestone:  5.2
Component:  Administration                       |     Version:
 Severity:  normal                               |  Resolution:
 Keywords:  site-health has-patch needs-testing  |     Focuses:  ui,
                                                 |  performance
-------------------------------------------------+-------------------------

Comment (by xkon):

 [attachment:"46707.2.diff"] is based on [attachment:"46707.1.diff"] but
 changes the calculation a little bit ( lines 1136 - 1203 ).

 Adds an extra value of `unformatted_size` on the path sizes for internal
 use of calculations and converts the Total size to use the `WordPress
 Directory Size` + `Database Size`.

 My finished calculations now are and look more reasonable ( if I was
 correct on this :D ):

 {{{
 4.21 MB   - Uploads Directory Size
 8.90 MB   - Themes Directory Size
 407.73 MB - Plugins Directory Size

 478.34 MB - WordPress Directory Size
 720.00 KB - Database size

 478.98 MB - Total installation size
 }}}

 By removing the is_subdir check, the debug notice from my previous reply
 is also gone. It was always empty for me so I'm not really sure what was
 it's purpose and I might be way off on this part but with the new "total"
 size calculation I don't think it's needed either way.

 Could you please give this a go as well just in case I wasn't wrong on
 this? Nothing else was touched except from the way we calculate the Total.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/46707#comment:17>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform