[wp-trac] [WordPress Trac] #46707: Site health: notify the user while gathering site data

WordPress Trac noreply at wordpress.org
Thu Apr 11 21:20:21 UTC 2019

#46707: Site health: notify the user while gathering site data
 Reporter:  azaozz                               |       Owner:  (none)
     Type:  defect (bug)                         |      Status:  new
 Priority:  normal                               |   Milestone:  5.2
Component:  Administration                       |     Version:
 Severity:  normal                               |  Resolution:
 Keywords:  site-health has-patch needs-testing  |     Focuses:  ui,
                                                 |  performance

Comment (by azaozz):

 Replying to [comment:11 afercia]:
 > I have lots of plugins (some of them with node_modules directories) so
 in my case it's expected to timeout. However, it seems it timeouts before
 30 seconds in ~22 seconds. Is this expected?

 Yes, currently the timeout is capped at ~20 seconds. Thinking to increase
 that to 25.

 > ...the dirsize calculation is cached for one hour. This might be
 confusing for users when they know their directories size has changed and
 they will still see the previous value.

 Yeah, was thinking about that too. The users may try deleting unused
 themes and plugins and then re-running this so check the size again. As
 this is ajax based now, we can calculate sizes without caching them. For
 that we'll probably need to add another param to `get_dirsize()` or use
 `recurse_dirsize()` directly.

 > When the dirsize values are cached, the results load almost immediately.
 In this case, I'd consider to ''not'' display and speak the message
 "Successfully calculated directory sizes."

 Yeah, looking at it again all these calculations are perhaps too
 "prominent". Thinking what @xkon suggests above would probably be better.

 > Minor: jshint isn't happy with a couple extra commas:
 > ...
 > I guess this rule should be removed as WordPress doesn't support old IE
 versions any longer, but for now it will error.

 Yep, no point of that rule any more. It's against the updated JS coding
 standards too.

Ticket URL: <https://core.trac.wordpress.org/ticket/46707#comment:13>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform

More information about the wp-trac mailing list