[wp-trac] [WordPress Trac] #46824: Unnecessary use of swappable arguments

WordPress Trac noreply at wordpress.org
Thu Apr 11 18:33:34 UTC 2019

#46824: Unnecessary use of swappable arguments
 Reporter:  tobifjellner              |       Owner:  SergeyBiryukov
     Type:  defect (bug)              |      Status:  reviewing
 Priority:  normal                    |   Milestone:  5.2
Component:  Administration            |     Version:  trunk
 Severity:  normal                    |  Resolution:
 Keywords:  good-first-bug has-patch  |     Focuses:
Changes (by SergeyBiryukov):

 * owner:  (none) => SergeyBiryukov
 * status:  new => reviewing
 * milestone:  Awaiting Review => 5.2


 Hi @thrijith, thanks for the patch!

 Just to clarify, `<span class="code">%s</span>` should not be added to the
 translatable string. We've been removing unnecessary HTML tags from
 strings for a while in
 some previous tickets].

 The first patch looks good, excerpt for the `wp-includes/class-wp-http-
 proxy.php` change.

 The translator comments above the strings should also be updated to
 replace `1:` with `%s:`.

Ticket URL: <https://core.trac.wordpress.org/ticket/46824#comment:3>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform

More information about the wp-trac mailing list