[wp-trac] [WordPress Trac] #45029: Changes by widget_{$this->id_base}_instance_schema are overridden by sub class.

WordPress Trac noreply at wordpress.org
Tue Apr 2 22:12:18 UTC 2019


#45029: Changes by widget_{$this->id_base}_instance_schema  are overridden by sub
class.
-------------------------------------------------+-------------------------
 Reporter:  Toro_Unit                            |       Owner:
                                                 |  SergeyBiryukov
     Type:  defect (bug)                         |      Status:  closed
 Priority:  normal                               |   Milestone:  5.2
Component:  Widgets                              |     Version:  4.9
 Severity:  normal                               |  Resolution:  fixed
 Keywords:  has-patch has-unit-tests dev-        |     Focuses:
  feedback                                       |
-------------------------------------------------+-------------------------
Changes (by SergeyBiryukov):

 * status:  reviewing => closed
 * resolution:   => fixed


Comment:

 In [changeset:"45100" 45100]:
 {{{
 #!CommitTicketReference repository="" revision="45100"
 Widgets: Make sure changes to media widgets' instance schema via
 `widget_{$this->id_base}_instance_schema` filter are not overridden by
 subclasses.

 Previously, `WP_Widget_Media_Audio`, `WP_Widget_Media_Image`, and
 `WP_Widget_Media_Video` used to override the changes due to reversed
 arguments in `array_merge()` call.

 Props Toro_Unit, birgire.
 Fixes #45029.
 }}}

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/45029#comment:13>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list