[wp-trac] [WordPress Trac] #45029: Changes by widget_{$this->id_base}_instance_schema are overridden by sub class.

WordPress Trac noreply at wordpress.org
Mon Apr 1 22:34:18 UTC 2019


#45029: Changes by widget_{$this->id_base}_instance_schema  are overridden by sub
class.
-------------------------------------------------+-------------------------
 Reporter:  Toro_Unit                            |       Owner:
                                                 |  SergeyBiryukov
     Type:  defect (bug)                         |      Status:  reviewing
 Priority:  normal                               |   Milestone:  5.2
Component:  Widgets                              |     Version:  4.9
 Severity:  normal                               |  Resolution:
 Keywords:  has-patch has-unit-tests dev-        |     Focuses:
  feedback                                       |
-------------------------------------------------+-------------------------

Comment (by SergeyBiryukov):

 Replying to [comment:9 birgire]:
 > We can e.g. compare it with {{{wp_parse_args( $options, $defaults )}}},
 that's a wrapper of {{{array_merge( $defaults, $options )}}}, regarding
 the expected input order.

 Could we use `wp_parse_args()` here as well, for consistency with the rest
 of core? That should prevent further confusion.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/45029#comment:10>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list