[wp-trac] [WordPress Trac] #38415: New Custom Link menu item has a wrong fallback label

[WordPress Trac]

#38415: New Custom Link menu item has a wrong fallback label
-------------------------------------------------+-------------------------
 Reporter:  afercia                              |       Owner:  (none)
     Type:  defect (bug)                         |      Status:  new
 Priority:  normal                               |   Milestone:  Future
                                                 |  Release
Component:  Menus                                |     Version:  4.5
 Severity:  normal                               |  Resolution:
 Keywords:  has-screenshots needs-patch good-    |     Focuses:  ui
  first-bug                                      |
-------------------------------------------------+-------------------------
Changes (by desrosj):

 * keywords:  has-screenshots => has-screenshots needs-patch good-first-bug
 * milestone:  Awaiting Review => Future Release


Old description:

> On the menus screen, when adding a Custom Link to a menu '''and leaving
> the link text field empty''', a default fallback `Menu Item` label was
> set:
>
> [[Image(https://cldup.com/xaDohbjzS9.png)]]
>
> On the latest versions though, the fallback label is ` (Pending)`, with a
> leading space:
>
> [[Image(https://cldup.com/zq1ti4qSnq.png)]]
>
> This was broken by [36379] 😬 my bad. Haven't looked in depth in the code
> but I think it could be fixed on the PHP side, I guess there's no need to
> restore the JS part that was removed in [36379].

New description:

 On the menus screen, when adding a Custom Link to a menu '''and leaving
 the link text field empty''', a default fallback `Menu Item` label was
 set:

 [[Image(https://cldup.com/xaDohbjzS9.png)]]

 On the latest versions though, the fallback label is ` (Pending)`, with a
 leading space:

 [[Image(https://cldup.com/zq1ti4qSnq.png)]]

 This was broken by [36379]  my bad. Haven't looked in depth in the code
 but I think it could be fixed on the PHP side, I guess there's no need to
 restore the JS part that was removed in [36379].

--

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/38415#comment:3>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform