[wp-trac] [WordPress Trac] #44545: Commented out code in admin-filters.php

WordPress Trac noreply at wordpress.org
Thu Sep 27 17:52:24 UTC 2018


#44545: Commented out code in admin-filters.php
---------------------------------------------+-----------------------------
 Reporter:  dilipbheda                       |       Owner:  Girishpanchal
     Type:  defect (bug)                     |      Status:  assigned
 Priority:  low                              |   Milestone:  5.0
Component:  General                          |     Version:  3.8
 Severity:  normal                           |  Resolution:
 Keywords:  has-patch good-first-bug commit  |     Focuses:  administration
---------------------------------------------+-----------------------------
Changes (by desrosj):

 * keywords:  has-patch => has-patch good-first-bug commit
 * owner:  (none) => Girishpanchal
 * focuses:  docs => administration
 * status:  new => assigned
 * version:   => 3.8


Comment:

 Thanks for the ticket, @dilipbheda!

 I did some digging to find out why these were commented out, and if there
 was a reason they were left in the codebase.

 These action hooks appear to be remnants of the old theme installing
 experience that was removed in 3.9 in favor of the
 [https://make.wordpress.org/core/2013/10/23/thx-presentation/ theme
 viewing experience introduced in 3.8 (THX)]. They were commented out in
 [27499] as a part of #27055 and later moved into `admin-filters.php` in
 [32653] as a part of #32529, but there was no obvious reason why they
 remained in the codebase.

 These should be safe to remove, but the above details should be mentioned
 in the commit for historical context.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/44545#comment:3>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list