[wp-trac] [WordPress Trac] #43632: Add a screen reader text for Hello Dolly lyrics

[WordPress Trac]

#43632: Add a screen reader text for Hello Dolly lyrics
---------------------------------------+----------------------------
 Reporter:  SergeyBiryukov             |       Owner:  audrasjb
     Type:  enhancement                |      Status:  assigned
 Priority:  normal                     |   Milestone:  4.9.9
Component:  Plugins                    |     Version:
 Severity:  normal                     |  Resolution:
 Keywords:  has-screenshots has-patch  |     Focuses:  accessibility
---------------------------------------+----------------------------

Comment (by audrasjb):

 Replying to [comment:31 birgire]:
 > I was wondering if we could move the extra space from the HTML tag, into
 the {{{$lang}}} variable?
 Sure, but I think we should also move it to a `span` element since the
 paragraphe is translatable now… :D

 > Also if we should use substr instead of strpos, since we are targeting
 the first three (non multibyte) chars?
 > Also if we could avoid a very long echo line.
 > So instead of:
 > […]
 > we might have:
 > […]
 You are totally right!

 > There seems to be ''English (Pirate)'' available too with
 {{{art_xpirate}}} ?
 > Should it be included here?
 Good catch!

 Do you want to add a new patch? I can make it but maybe you are about to
 do so… :)

 Thanks,

 Jb

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/43632#comment:32>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform