[wp-trac] [WordPress Trac] #44081: Privacy email request failures do not get reported if there are also successful ones

[WordPress Trac]

#44081: Privacy email request failures do not get reported if there are also
successful ones
-------------------------------------------------+-------------------------
 Reporter:  desrosj                              |       Owner:  javorszky
     Type:  defect (bug)                         |      Status:  assigned
 Priority:  normal                               |   Milestone:  4.9.9
Component:  Privacy                              |     Version:  4.9.6
 Severity:  normal                               |  Resolution:
 Keywords:  has-patch has-screenshots ui-        |     Focuses:
  feedback                                       |  administration
-------------------------------------------------+-------------------------

Comment (by javorszky):

 > was there a reason why you went with two notices (green and red) instead
 of one warning notice (orange)?

 Yup. This is the relevant docblock for the `add_settings_error` function:

 {{{#!php
  * @param string $type    Optional. Message type, controls HTML class.
 Accepts 'error' or 'updated'.
  *                        Default 'error'.
  */
 function add_settings_error( $setting, $code, $message, $type = 'error' )
 {
         global $wp_settings_errors;

         $wp_settings_errors[] = array(
                 'setting' => $setting,
                 'code'    => $code,
                 'message' => $message,
                 'type'    => $type,
         );
 }
 }}}

 I took the liberty of believing the inline documentation instead of going
 hunting for the actual declared css classes that are available to me.

 I'll fix up the spacing issue.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/44081#comment:23>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform