[wp-trac] [WordPress Trac] #44883: Twenty Seventeen: Use simple counter rather than uniqid() for generating unique IDs for HTML elements

WordPress Trac noreply at wordpress.org
Fri Sep 7 04:46:06 UTC 2018


#44883: Twenty Seventeen: Use simple counter rather than uniqid() for generating
unique IDs for HTML elements
---------------------------+----------------------------
 Reporter:  westonruter    |       Owner:  laurelfulford
     Type:  enhancement    |      Status:  reviewing
 Priority:  normal         |   Milestone:  4.9.9
Component:  Bundled Theme  |     Version:  4.7
 Severity:  normal         |  Resolution:
 Keywords:  has-patch      |     Focuses:
---------------------------+----------------------------

Comment (by westonruter):

 Replying to [comment:5 dlh]:
 > Replying to [comment:4 westonruter]:
 > > Like a `wp_unique_id()` function added to `wp-includes/functions.php`?
 >
 > Yep, exactly that.

 That's a good idea, but I just realized that it wouldn't be suitable in
 this case for Twenty Seventeen because the theme needs to work backwards
 to the 4.7 branch.

 See [attachment:"44883.1.diff"] which still retains a
 `twentyseventeen_unique_id()` in Twenty Seventeen, but uses a new
 `wp_unique_id()` when it is available.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/44883#comment:6>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list