[wp-trac] [WordPress Trac] #45151: Convert 'Sample Page', 'Hello World', and 'Privacy Policy' to block content

WordPress Trac noreply at wordpress.org
Tue Oct 23 20:42:13 UTC 2018


#45151: Convert 'Sample Page', 'Hello World', and 'Privacy Policy' to block content
-------------------------------------------------+-----------------------
 Reporter:  danielbachhuber                      |       Owner:  desrosj
     Type:  enhancement                          |      Status:  assigned
 Priority:  normal                               |   Milestone:  5.0
Component:  Upgrade/Install                      |     Version:
 Severity:  normal                               |  Resolution:
 Keywords:  has-patch needs-testing 2nd-opinion  |     Focuses:
-------------------------------------------------+-----------------------

Comment (by garrett-eclipse):

 Thanks @desrosj I haven't plugged this in for testing but from an initial
 code review;
 * In your docblock for $blocks please provide the 'Default true.'
 * Should we add a 'wp_get_default_privacy_policy_strings' filter for the
 array before the foreach so plugins/devs can manipulate the strings array
 adding additional headings and paragraphs without needing to think about
 the Block Editor formatting?
 * If we do add a filter to the strings array should we make it a
 dictionary with keys so plugins can manipulate specific sections like
 'Comments' more easily?
 * Should the h2 replace set a level of 2 for the gutenberg markup?

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/45151#comment:6>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list