[wp-trac] [WordPress Trac] #45042: Twenty Fourteen: Update theme to add Gutenberg styles and support

WordPress Trac noreply at wordpress.org
Fri Oct 19 18:07:43 UTC 2018

#45042: Twenty Fourteen: Update theme to add Gutenberg styles and support
 Reporter:  laurelfulford            |       Owner:  laurelfulford
     Type:  task (blessed)           |      Status:  assigned
 Priority:  normal                   |   Milestone:  5.0
Component:  Bundled Theme            |     Version:
 Severity:  normal                   |  Resolution:
 Keywords:  has-patch needs-testing  |     Focuses:

Comment (by laurelfulford):

 Thanks @ianbelanger!

 [attachment:"45042.4.patch"] includes fixes for the following:

 * Specifies the correct `line-height` for the button block and button in
 the File block in the editor, so the height of the button matches the
 height on the front-end.
 * Adds a space between columns in the column block.

 Also to circle back to the Media Element JS, which I kind of left hanging:

 > Twenty Fourteen includes custom styling for media players (video and
 audio), including in the editor. It appears that this is broken by
 Guntenberg and needs to be added to the block editor styles based on the
 screenshots posted so far.

 At the moment, the Media Element JS is only loaded for audio players when
 they're added to the Classic block. It is not loaded for videos in that
 case -- something I still want to look into, because I'm curious about the
 "why", but that's not specific to this theme. It is not loaded for the
 audio or video blocks on the front or back end, at least right now.

 For Twenty Fourteen, for now, this means it won't be possible to style
 these blocks with the theme's audio and video styles. If that changes down
 the road, I think the styles should inherit for the most part, but if not
 we can tackle them in a new ticket :)

Ticket URL: <https://core.trac.wordpress.org/ticket/45042#comment:9>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform

More information about the wp-trac mailing list