[wp-trac] [WordPress Trac] #45131: Paths are incorrect in multisite.xml

[WordPress Trac]

#45131: Paths are incorrect in multisite.xml
------------------------------+------------------------------
 Reporter:  danielbachhuber   |       Owner:  (none)
     Type:  defect (bug)      |      Status:  new
 Priority:  normal            |   Milestone:  Awaiting Review
Component:  Build/Test Tools  |     Version:
 Severity:  normal            |  Resolution:
 Keywords:  dev-feedback      |     Focuses:  multisite
------------------------------+------------------------------
Description changed by danielbachhuber:

Old description:

> In [25294], the base directory for `<exclude>` files was changed from
> `tests/` to `tests/phpunit/tests/`, e.g.
>
> {{{
> <exclude>tests/phpunit/tests/actions/closures.php</exclude>
> }}}
>
> However, when Grunt runs `phpunit -c tests/phpunit/multisite.xml
> --verbose` from the project root, `<exclude>` paths are calculated
> relative to the location of `multisite.xml`.
>
> Maybe PHPUnit changed how it calculate paths? Here's how I discovered it:
>
> * Failed build: https://github.com/danielbachhuber/wordpress-
> develop/pull/2/commits/68970705bc0c06f13b744999bc9d7bad338fbae7
> * Passed build: https://github.com/danielbachhuber/wordpress-
> develop/pull/2/commits/8a3a9949225ee84b81463682953c210aab31d264
>
> From https://github.com/danielbachhuber/wordpress-develop/pull/2

New description:

 In [25294], the base directory for `<exclude>` files was changed from
 `tests/` to `tests/phpunit/tests/`, e.g.

 {{{
 <exclude>tests/phpunit/tests/actions/closures.php</exclude>
 }}}

 However, when Grunt runs `phpunit -c tests/phpunit/multisite.xml
 --verbose` from the project root, `<exclude>` paths are calculated
 relative to the location of `multisite.xml`.

 I ''think'' [25294] is wrong, and the path should be:

 {{{
 <exclude>tests/actions/closures.php</exclude>
 }}}

 Maybe PHPUnit changed how it calculate paths? Here's how I discovered it:

 * Failed build: https://github.com/danielbachhuber/wordpress-
 develop/pull/2/commits/68970705bc0c06f13b744999bc9d7bad338fbae7
 * Passed build: https://github.com/danielbachhuber/wordpress-
 develop/pull/2/commits/8a3a9949225ee84b81463682953c210aab31d264

 From https://github.com/danielbachhuber/wordpress-develop/pull/2

--

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/45131#comment:2>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform