[wp-trac] [WordPress Trac] #45045: Twenty Seventeen: Update theme to add Gutenberg styles and support

WordPress Trac noreply at wordpress.org
Wed Oct 17 20:01:55 UTC 2018

#45045: Twenty Seventeen: Update theme to add Gutenberg styles and support
 Reporter:  laurelfulford                        |       Owner:
                                                 |  laurelfulford
     Type:  task (blessed)                       |      Status:  assigned
 Priority:  normal                               |   Milestone:  5.0
Component:  Bundled Theme                        |     Version:
 Severity:  normal                               |  Resolution:
 Keywords:  has-patch needs-testing has-         |     Focuses:
  screenshots                                    |

Comment (by laurelfulford):

 Updated [attachment:"45045.2.patch"] with the following:
 * Incorporated non-wide alignment changes from @ianbelanger’s patch;
 confirmed this takes care of the cover image, separator & blockquote
 issues listed above. Ran into some additional weirdness with aligned
 blockquotes that should all be fixed.
 * Removed editor colour palette for now, as per the comment
 [https://core.trac.wordpress.org/ticket/45045#comment:16 here].
 * Fixed some issues I’d found while making other patches and meant to
 comment on here, like making sure the Custom HTML block doesn’t inherit
 styles from `pre` in the editor
 * Did another quick pass and fixed some minor issues, as well as adjusted
 some styles for RTL.
 * Removed some styles from the editor-blocks.css that became redundant
 after adding theme support for `editor-styles`.

 > I think we should get the editor/front-end styles nailed first before
 adding more on.

 @davidakennedy That's a good point, it’s probably a good idea to keep
 things focused at this point. I’d added some wide alignments to Twenty
 Thirteen as well - does it make sense to take those out for now, too?

Ticket URL: <https://core.trac.wordpress.org/ticket/45045#comment:28>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform

More information about the wp-trac mailing list