[wp-trac] [WordPress Trac] #45435: Port Gutenberg's `removep` Function to Php

WordPress Trac noreply at wordpress.org
Fri Nov 30 15:54:56 UTC 2018


#45435: Port Gutenberg's `removep` Function to Php
--------------------------------------+------------------------------
 Reporter:  conner_bw                 |       Owner:  (none)
     Type:  enhancement               |      Status:  new
 Priority:  normal                    |   Milestone:  Awaiting Review
Component:  Editor                    |     Version:  4.9.8
 Severity:  normal                    |  Resolution:
 Keywords:  has-patch has-unit-tests  |     Focuses:
--------------------------------------+------------------------------
Changes (by gaveline):

 * keywords:   => has-patch has-unit-tests


Comment:

 Here's my diff file attached to the ticket.
 I nearly write line toi line code from JS file and test each case.
 Since implementation may be refactored and enhanced, tests will simplify
 the task.

 Changes
 {{{
  src/wp-includes/formatting.php             | 139 ++++++++
  tests/phpunit/tests/formatting/Removep.php | 351 +++++++++++++++++++++
  2 files changed, 490 insertions(+)
  create mode 100644 tests/phpunit/tests/formatting/Removep.php
 }}}

 Running test for this ticket :
 {{{phpunit --group 45435}}}

 {{{
 .............                                                     13 / 13
 (100%)

 Time: 10.98 seconds, Memory: 144.00MB

 OK (13 tests, 13 assertions)
 }}}

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/45435#comment:2>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list