[wp-trac] [WordPress Trac] #44416: `compact()` will throw notice for undefined variables in PHP 7.3

[WordPress Trac]

#44416: `compact()` will throw notice for undefined variables in PHP 7.3
---------------------------------------+-----------------------------
 Reporter:  desrosj                    |       Owner:  SergeyBiryukov
     Type:  defect (bug)               |      Status:  reopened
 Priority:  normal                     |   Milestone:  5.0
Component:  General                    |     Version:
 Severity:  normal                     |  Resolution:
 Keywords:  php73 fixed-5.0 has-patch  |     Focuses:
---------------------------------------+-----------------------------
Changes (by desrosj):

 * keywords:  needs-testing php73 needs-patch fixed-5.0 => php73 fixed-5.0
     has-patch


Comment:

 PHP 7.3 is scheduled to be [https://wiki.php.net/todo/php73 released on
 December 6th]. If 5.0 is not released prior to this date, a 4.9.9 may be
 released as previously discussed.

 [attachment:"44416.2.diff"] is a patch to backport [43819] and [43832] to
 the 4.9 branch.

 Here is a [https://travis-ci.org/desrosj/wordpress-
 develop/builds/461389993 build on Travis showing all of the issues with
 compact are addressed. Note: this build also includes a backport of
 [43899], which prevents the entire test suite from running successfully to
 prove this patch is working.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/44416#comment:19>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform