[wp-trac] [WordPress Trac] #45432: Twenty Twelve: Button blocks don't apply custom colours

WordPress Trac noreply at wordpress.org
Tue Nov 27 17:50:23 UTC 2018


#45432: Twenty Twelve: Button blocks don't apply custom colours
-------------------------------------------------+-------------------------
 Reporter:  laurelfulford                        |       Owner:
                                                 |  laurelfulford
     Type:  defect (bug)                         |      Status:  assigned
 Priority:  normal                               |   Milestone:  5.0
Component:  Bundled Theme                        |     Version:  5.0
 Severity:  normal                               |  Resolution:
 Keywords:  has-patch needs-testing has-         |     Focuses:
  screenshots                                    |
-------------------------------------------------+-------------------------

Comment (by laurelfulford):

 [attachment:"45432.patch"] adjusts the specificity of the button colour
 selectors for the front end, so the custom colours can override them. It
 also takes the `:visited` colours into account, so the custom colours can
 also override them to make sure there's enough contrast.

 Lastly, it makes it so the button gradient is only applied when there is
 no background colour, so it doesn't cover it up in the editor and on the
 front end.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/45432#comment:1>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list