[wp-trac] [WordPress Trac] #45145: Keep `@wordpress` packages up to date

WordPress Trac noreply at wordpress.org
Tue Nov 20 23:49:38 UTC 2018


#45145: Keep `@wordpress` packages up to date
----------------------------------------+-----------------------
 Reporter:  atimmer                     |       Owner:  (none)
     Type:  defect (bug)                |      Status:  assigned
 Priority:  highest omg bbq             |   Milestone:  5.0
Component:  Build/Test Tools            |     Version:  5.0
 Severity:  blocker                     |  Resolution:
 Keywords:  has-patch commit fixed-5.0  |     Focuses:
----------------------------------------+-----------------------

Comment (by mcsf):

 [https://core.trac.wordpress.org/attachment/ticket/45145/45145.6.diff
 45145.6.diff] constitutes a first pass, including:

 - An updated `package.json` thanks to the `ncu` tool as pointed out by
 Andrew in #comment:47.
 - A manually updated dependency tree in `script-loader.php` built from
 Gutenberg's `packages-dependencies.php`.
 - Manually merged changes from Gutenberg's `client-assets.php`.
 - A fix in `tools/webpack/packages.js` based on
 [https://github.com/WordPress/gutenberg/pull/12006/files#diff-
 11e9f7f953edc64ba14b0cc350ae7b9dR170 gb-12006].

 As it's the middle of the night here, it's time for me to pass the baton.
 **Please** properly check the diff, in particular where it concerns
 TinyMCE (the line for a new plugin, `tinymce-latest-lists`, was blindly
 copied to `$vendor_scripts`), and there's a discrepancy where it reads
 `wp_adv` (though it's probably Gutenberg the plugin which is wrong on this
 one).

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/45145#comment:52>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list