[wp-trac] [WordPress Trac] #38323: Reconsider $object_subtype handling in `register_meta()`

WordPress Trac noreply at wordpress.org
Thu May 31 19:56:54 UTC 2018


#38323: Reconsider $object_subtype handling in `register_meta()`
-------------------------------------------------+-------------------------
 Reporter:  flixos90                             |       Owner:  flixos90
     Type:  enhancement                          |      Status:  assigned
 Priority:  normal                               |   Milestone:  5.0
Component:  Options, Meta APIs                   |     Version:
 Severity:  normal                               |  Resolution:
 Keywords:  has-patch needs-unit-tests needs-    |     Focuses:  rest-api
  dev-note                                       |
-------------------------------------------------+-------------------------

Comment (by jeremyfelt):

 I haven't had a chance to test this out in full yet, but the direction and
 patch are looking nice. :thumbsup:

 One thing that caught my eye is how many line changes there are in
 existing tests. Most (almost all?) of this seems like it can be done
 without the object subtype handling (e.g. the conversion to static
 `$author`, `$post_id`, `$post_id_2` throughout). I would commit that first
 to better convey what is actually changing in the tests vs being added as
 new in the introduction of subtype handling.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/38323#comment:64>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list