[wp-trac] [WordPress Trac] #44236: Maintain consistency between privacy export report and archive filenames

WordPress Trac noreply at wordpress.org
Sat May 26 00:03:07 UTC 2018


#44236: Maintain consistency between privacy export report and archive filenames
--------------------------+-----------------------------
 Reporter:  iandunn       |      Owner:  (none)
     Type:  defect (bug)  |     Status:  new
 Priority:  low           |  Milestone:  Awaiting Review
Component:  Privacy       |    Version:  4.9.6
 Severity:  minor         |   Keywords:  good-first-bug
  Focuses:                |
--------------------------+-----------------------------
 Prior to r43180, the export `.zip` filename changed every time it was
 regenerated; after that commit, it was reused to ensure links aren't
 broken (see #43905).

 That commit didn't do anything to the `.html` filename, though, so after
 the initial regeneration, the value of `$obscura` will not match between
 the two filenames. I don't think this presents any issues for Core, and
 might not for plugins either, but it seems like they should be consistent,
 just to be safe.

 If a plugin hooks into `wp_privacy_personal_data_export_file_created`, it
 may reasonably assume that the filenames to match, and do something like
 `str_replace( '.html', '.zip', $foo )`. That seems unlikely, since both
 filenames are passed to the callback, but it's better to be safe than
 sorry.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/44236>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list