[wp-trac] [WordPress Trac] #44045: GDPR WP Pointer dismiss link can be unreachable

[WordPress Trac]

#44045: GDPR WP Pointer dismiss link can be unreachable
------------------------------------------+--------------------------------
 Reporter:  imath                         |       Owner:  iandunn
     Type:  defect (bug)                  |      Status:  closed
 Priority:  normal                        |   Milestone:  4.9.6
Component:  Administration                |     Version:  trunk
 Severity:  normal                        |  Resolution:  fixed
 Keywords:  gdpr has-patch needs-testing  |     Focuses:  ui,
                                          |  administration
------------------------------------------+--------------------------------
Changes (by iandunn):

 * status:  accepted => closed
 * resolution:   => fixed


Comment:

 In [changeset:"43246" 43246]:
 {{{
 #!CommitTicketReference repository="" revision="43246"
 Privacy: Reposition pointer to ensure dismiss link is always visible.

 r43158 introduced a new admin pointer for the privacy tools added in
 4.9.6. With the previous positioning, though, sometimes the `Dismiss` link
 would be fixed off screen, making it impossible for the user to dismiss
 the pointer. This happened when there were enough extra menu items, or
 when the viewport height was short enough.

 This commit repositions the pointer to work around that problem. One down
 side of this workaround is that the arrow will not always be positioned
 next to the `Tools` menu, where it should be. That's an acceptable
 compromise given the current time constraints, though. A long term
 solution would be to make `WP_Pointer` robust enough to handle this use
 case.

 Props imath, audrasjb, desrosj.
 Fixes #44045.
 }}}

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/44045#comment:8>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform