[wp-trac] [WordPress Trac] #43929: Privacy pages: buttons should be buttons and other coding standards

[WordPress Trac]

#43929: Privacy pages: buttons should be buttons and other coding standards
------------------------------------------+-------------------------------
 Reporter:  afercia                       |       Owner:  (none)
     Type:  defect (bug)                  |      Status:  new
 Priority:  normal                        |   Milestone:  4.9.6
Component:  Administration                |     Version:  trunk
 Severity:  normal                        |  Resolution:
 Keywords:  gdpr has-patch needs-testing  |     Focuses:  coding-standards
------------------------------------------+-------------------------------

Comment (by desrosj):

 Thanks, @allendav. I fixed that missed text. I also added `class="button"`
 to the remove request links, but left them as links.

 Looking at the [https://make.wordpress.org/core/handbook/best-practices
 /coding-standards/accessibility-coding-standards/#semantics-for-controls
 a11y handbook], it seems like these links are recommended to be `<a>`
 tags.

   If there is a valid target link for the control, either an in-page
 reference or a link, then the control should use an `<a href="">`

 @afercia could confirm. But I think this is ready to go.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/43929#comment:14>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform