[wp-trac] [WordPress Trac] #43929: Privacy pages: buttons should be buttons and other coding standards

[WordPress Trac]

#43929: Privacy pages: buttons should be buttons and other coding standards
------------------------------------------+-------------------------------
 Reporter:  afercia                       |       Owner:  (none)
     Type:  defect (bug)                  |      Status:  new
 Priority:  normal                        |   Milestone:  4.9.6
Component:  Administration                |     Version:  trunk
 Severity:  normal                        |  Resolution:
 Keywords:  gdpr has-patch needs-testing  |     Focuses:  coding-standards
------------------------------------------+-------------------------------
Changes (by desrosj):

 * keywords:  gdpr has-patch needs-refresh => gdpr has-patch needs-testing


Comment:

 [attachment:43929.4.diff] is a refresh. Some of the action label text had
 changed (r43175), so please double check that for me.

 Also in the refresh:

 - Remove `preventDefault()`
 - Ensure all `<buttons>` have `type="button"`
 - Change translation inline comments to use `/* translators: a note */`
 instead of `// translators: a note */`

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/43929#comment:12>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform