[wp-trac] [WordPress Trac] #43929: Privacy pages: buttons should be buttons and other coding standards

[WordPress Trac]

#43929: Privacy pages: buttons should be buttons and other coding standards
------------------------------------------+-------------------------------
 Reporter:  afercia                       |       Owner:  (none)
     Type:  defect (bug)                  |      Status:  new
 Priority:  normal                        |   Milestone:  4.9.6
Component:  Administration                |     Version:  trunk
 Severity:  normal                        |  Resolution:
 Keywords:  gdpr has-patch needs-testing  |     Focuses:  coding-standards
------------------------------------------+-------------------------------
Changes (by xkon):

 * keywords:  gdpr needs-patch => gdpr has-patch needs-testing


Comment:

 [attachment:43929.diff]

 Thanks @afercia for taking time to check things.

 - converts `<a>` to `<buttons>` where needed in `user.php`
 - converts all css classes with `-` instead of `_` in `user.php`
 - groups `vars` in `xfn.js`
 - fixes various coding standards in `user.php / xfn.js`

 I tested everything ( using trunk ) but please do thorough tests as all
 action handlers etc have been touched :]

 `Note: I didn't mess with non-privacy code so there are still a couple of
 CS notices in those files.`

 cc @allendav ( pinging since you know these actions better than anyone :D
 )

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/43929#comment:4>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform