[wp-trac] [WordPress Trac] #43663: Unit Test test_theme_file_uri_returns_valid_uri fails on directories with spaces

[WordPress Trac]

#43663: Unit Test test_theme_file_uri_returns_valid_uri fails on directories with
spaces
------------------------------------+------------------------------
 Reporter:  mattkeys                |       Owner:
     Type:  defect (bug)            |      Status:  new
 Priority:  normal                  |   Milestone:  Awaiting Review
Component:  Build/Test Tools        |     Version:  4.9.5
 Severity:  normal                  |  Resolution:
 Keywords:  dev-feedback has-patch  |     Focuses:
------------------------------------+------------------------------
Changes (by birgire):

 * keywords:  dev-feedback has-patch needs-testing => dev-feedback has-patch


Comment:

 @mattkeys great, thanks for the testing.

 ps:

 There is ticket #30206 but I don't think it's the same issue though.

 Then one can wonder about the edge case, when the full directory path is
 returned, if that should be handled to support spaces?

 But I just stumbled up on
 [https://core.trac.wordpress.org/ticket/23661#comment:1 this comment] by
 {{{@nacin}}}, an interesting idea to add a second URL argument to
 {{{register_theme_directory()}}}.

 That would be one way to avoid the above edge case.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/43663#comment:4>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform