[wp-trac] [WordPress Trac] #42724: Options Media page hides breaks on desktop

[WordPress Trac]

#42724: Options Media page hides breaks on desktop
-------------------------------------------------+-------------------------
 Reporter:  garrett-eclipse                      |       Owner:
     Type:  defect (bug)                         |      Status:  new
 Priority:  normal                               |   Milestone:  4.9.5
Component:  Media                                |     Version:  4.9
 Severity:  normal                               |  Resolution:
 Keywords:  has-patch needs-testing has-         |     Focuses:
  screenshots                                    |  accessibility
-------------------------------------------------+-------------------------
Changes (by afercia):

 * keywords:  has-patch needs-testing => has-patch needs-testing has-
     screenshots


Comment:

 [attachment:42724.2.diff] follows the previous approach, making the pairs
 of label + input always stacked vertically, also on bigger screens. This
 introduces a visual change, but I think it aligns nicely and it's the
 simplest approach.

 It also uses a `min-width` on the labels to make the inputs align
 vertically, to some extent. I've tested with several languages and seems
 to me it's good enough. If in a particular language one of these labels
 happen to be very long, nothing will break:  the input field will just be
 a bit shifted on the right. The min-width approach is already used in the
 general settings page.

 The CSS selectors target only the "size" labels and fields. Properties are
 simple enough. @RavanH I've tested with your plugin and haven't noticed
 any breakage. Please double check when you have a chance :)

 The patch also adds a missing fieldset + legend (thanks @RavanH!) to wrap
 the two "Thumbnail size" fields, leaving the checkbox out of the fieldset.
 See screenshot below, in English and French.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/42724#comment:29>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform