[wp-trac] [WordPress Trac] #43568: E_WARNING: sprintf(): Too few arguments. [ wp-activate.php wp-activate.php (113) ]

[WordPress Trac]

#43568: E_WARNING: sprintf(): Too few arguments. [ wp-activate.php wp-activate.php
(113) ]
--------------------------------+-----------------------------
 Reporter:  conner_bw           |      Owner:
     Type:  defect (bug)        |     Status:  new
 Priority:  normal              |  Milestone:  Awaiting Review
Component:  Networks and Sites  |    Version:  4.9.4
 Severity:  normal              |   Keywords:
  Focuses:  multisite           |
--------------------------------+-----------------------------
 We keep seeing E_WARNING: sprintf(): Too few arguments. [ wp-activate.php
 wp-activate.php (113) ] In our New Relic logs.

 The problem is this line:

 [https://github.com/WordPress/wordpress-
 develop/blob/77c996671f171482fb36c44b803768e06998eb3a/src/wp-
 activate.php#L113 Source]

 {{{#!php
 <?php
 sprintf( '<a href="http://%s">%s</a>', $signup->domain )
 }}}

 Count the number of %s. Count the args. Should probably be:

 {{{#!php
 <?php
 sprintf( '<a href="http://%s">%s</a>', $signup->domain, $signup->domain )
 }}}

 Thanks.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/43568>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform