[wp-trac] [WordPress Trac] #43481: Add tabs and placeholders to privacy tools page in wp-admin

WordPress Trac noreply at wordpress.org
Thu Mar 15 23:58:49 UTC 2018


#43481: Add tabs and placeholders to privacy tools page in wp-admin
------------------------------+------------------------------
 Reporter:  xkon              |       Owner:
     Type:  enhancement       |      Status:  new
 Priority:  normal            |   Milestone:  Awaiting Review
Component:  General           |     Version:
 Severity:  normal            |  Resolution:
 Keywords:  gdpr 2nd-opinion  |     Focuses:
------------------------------+------------------------------

Comment (by allendav):

 Thank you @xkon ! I think we are almost there!

 I tested it out and looked at it - I noticed you changed it to "WordPress
 Core" - i really recommend just "WordPress" to be consistent with the rest
 of the WordPress admin UI.

 > For the Flow you mention, we are still missing an extra table for
 exports in there, no :D

 Hmmm - good point - #43546 will deliver that. How about replacing the
 redundant Anonymize flow with "Export Personal Data" or some such for now?
 I'll noodle on that ticket's UI tomorrow but we can run with your
 placeholder UI I think for now.

 > As for the titles and _e etc you mentioned...

 I still see a few esc_attr_e in the table headings (e.g. ID, Full Name,
 etc) that should be esc_html_e I think - those won't be changing, so we
 should probably fix those now before they accidentally survive too long :P

 And one last thing I missed previously... the 'type' key in the requests -
 with that uppercase first letter there it looks like it is a user facing
 string (that missed translation) - how about using a constant instead or
 at least an all lowercase string? I know these are dummy values for the
 moment :)

--
Ticket URL: <https://core.trac.wordpress.org/ticket/43481#comment:14>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list