[wp-trac] [WordPress Trac] #42785: Change default of `show_in_rest` in register_post_type and register_taxonomy

WordPress Trac noreply at wordpress.org
Tue Mar 13 08:32:03 UTC 2018


#42785: Change default of `show_in_rest` in register_post_type and
register_taxonomy
-------------------------+--------------------
 Reporter:  joehoyle     |       Owner:
     Type:  enhancement  |      Status:  new
 Priority:  normal       |   Milestone:  4.9.5
Component:  REST API     |     Version:
 Severity:  normal       |  Resolution:
 Keywords:  has-patch    |     Focuses:
-------------------------+--------------------
Changes (by audrasjb):

 * keywords:  has-patch 2nd-opinion reporter-feedback => has-patch


Comment:

 Hello,

 I tested your last patch and it looks good to me. I think this can land in
 4.9.5 "as it".

 As a reminder, here is the result of this patch, for both custom post
 types and taxonomies:
 - parameter `public` set to `true` : `show_in_rest` is set to `true` by
 default
 - parameter `publicly_queryable` set to `true` : `show_in_rest` is set to
 `true` by default
 When parameters are combinated with different values, show_in_rest is
 always set to true by default since there is a OR condition.

 I guess another ticket should follow up to force `show_in_rest` to `true`
 for logged in users to help Gutenberg to work in custom post types.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/42785#comment:12>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list