[wp-trac] [WordPress Trac] #41986: Use regular core button styling for page header buttons

WordPress Trac noreply at wordpress.org
Fri Mar 9 08:36:36 UTC 2018


#41986: Use regular core button styling for page header buttons
-------------------------------------------------+-------------------------
 Reporter:  melchoyce                            |       Owner:
     Type:  enhancement                          |      Status:  new
 Priority:  normal                               |   Milestone:  Awaiting
Component:  General                              |  Review
 Severity:  normal                               |     Version:
 Keywords:  ui-feedback has-patch needs-refresh  |  Resolution:
                                                 |     Focuses:  ui,
                                                 |  administration
-------------------------------------------------+-------------------------
Changes (by danieltj):

 * keywords:  ui-feedback 2nd-opinion has-patch => ui-feedback has-patch
     needs-refresh


Comment:

 Wow, it's been a while since I last commented on this! After re-reading
 your comments (both @melchoyce and @helen) I've changed my mind and agree
 that perhaps it's better to use the grey button styling (secondary) for
 this. I have seen some plugins use that button in the header as it
 currently is, I have a plugin or two that do use it for consistency across
 `wp-admin`.

 I think updating all of the buttons in this area to have the `button
 button-secondary` class is probably the best way to go for most instances.
 I don't know how we'd successfully split test something like this,
 although making this button slightly more grey (removing the blue border
 and text) probably won't make too big of a difference.

 I think it's just important to ensure we know the purpose of this button
 in each instance it occurs and what it's actually used for because I do
 see it personally as a primary action in some places (the All Posts page)
 but others, I see it more of a secondary action. Whichever intention is
 chosen, I think removing the currently button styling and making it more
 consistent is the way forward, whether it uses the grey secondary or blue
 primary styling.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/41986#comment:9>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list