[wp-trac] [WordPress Trac] #43458: No placeholder for ico file in list view of Media Library

[WordPress Trac]

#43458: No placeholder for ico file in list view of Media Library
--------------------------------------+--------------------
 Reporter:  Guido07111975             |       Owner:
     Type:  defect (bug)              |      Status:  new
 Priority:  normal                    |   Milestone:  5.0
Component:  Media                     |     Version:  4.9.4
 Severity:  normal                    |  Resolution:
 Keywords:  good-first-bug has-patch  |     Focuses:
--------------------------------------+--------------------

Comment (by SergeyBiryukov):

 Thanks for the patch, @remyvv! It works as expected.

 The only thing I noted is that `IMAGETYPE_ICO` is only available in PHP
 5.3+, while WordPress still supports 5.2.4+, so we'll have to check if
 it's defined.

 It's also worth mentioning that metadata will only be generated for new
 icons, the ones previously uploaded will be left as is.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/43458#comment:4>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform