[wp-trac] [WordPress Trac] #42399: $error variable in login action is probably undefined all the time

[WordPress Trac]

#42399: $error variable in login action is probably undefined all the time
------------------------------------+----------------------
 Reporter:  nextendweb              |       Owner:
     Type:  defect (bug)            |      Status:  closed
 Priority:  normal                  |   Milestone:
Component:  Login and Registration  |     Version:  4.9
 Severity:  normal                  |  Resolution:  wontfix
 Keywords:                          |     Focuses:
------------------------------------+----------------------
Changes (by SergeyBiryukov):

 * status:  new => closed
 * resolution:   => wontfix
 * milestone:  Awaiting Review =>


Comment:

 Hi @nextendweb, thanks for the ticket!

 The `$error` global used to be set in the `wp_login()` pluggable function,
 which is unused since [6643] and was formally deprecated in [13093].

 The check in question was left for backward compatibility. The global is
 also checked in [source:tags/4.9.4/src/wp-login.php#L199 login_header()].

 A brief search in the Plugin Directory shows that some plugins still use
 the global, so I guess it's better to leave it as is for the time being.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/42399#comment:1>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform