[wp-trac] [WordPress Trac] #38323: Reconsider $object_subtype handling in `register_meta()`

WordPress Trac noreply at wordpress.org
Mon Jun 11 16:51:59 UTC 2018


#38323: Reconsider $object_subtype handling in `register_meta()`
-------------------------------------------------+-------------------------
 Reporter:  flixos90                             |       Owner:  flixos90
     Type:  enhancement                          |      Status:  assigned
 Priority:  normal                               |   Milestone:  5.0
Component:  Options, Meta APIs                   |     Version:
 Severity:  normal                               |  Resolution:
 Keywords:  has-patch needs-unit-tests needs-    |     Focuses:  rest-api
  dev-note                                       |
-------------------------------------------------+-------------------------

Comment (by spacedmonkey):

 My worry is about loading the main object in `get_object_subtype`. There
 have been times where I have not loaded meta using a list of ids (from say
 the options table) and haven't run the normal query class, like
 `WP_Query`. For custom migration code, where the whole object is not
 required is an example. This change may have massive performance effects
 on high end users, this change will not be massively sign posted and well
 documented.

 I disagree with the comment about comment types, as core supports pingback
 and trackbacks, which are well known. I also don't understand why to limit
 the functionality? You are already loading the comment.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/38323#comment:69>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list