[wp-trac] [WordPress Trac] #44240: Avoid running full PHPUnit test suite for every PHP file change

WordPress Trac noreply at wordpress.org
Fri Jun 8 04:32:29 UTC 2018


#44240: Avoid running full PHPUnit test suite for every PHP file change
------------------------------+---------------------
 Reporter:  jeremyfelt        |       Owner:  (none)
     Type:  enhancement       |      Status:  new
 Priority:  normal            |   Milestone:  5.0
Component:  Build/Test Tools  |     Version:
 Severity:  normal            |  Resolution:
 Keywords:  has-patch         |     Focuses:
------------------------------+---------------------

Comment (by jeremyfelt):

 Thanks for testing this!

 Replying to [comment:7 birgire]:
 > I guess I'm too influenced by PHP array item checks, but should we check
 e.g. if {{{grunt.cli.tasks.length > 0}}} since we are checking
 {{{grunt.cli.tasks[ 0 ]}}} ?
 >
 > I tested {{{grunt}}} without tasks and it doesn't seem to mind skipping
 such a check. The {{{grunt.cli.tasks[ 0 ]}}} is also used elsewhere in
 {{{Gruntfile.js}}} without such a check.

 I think we're okay here as the only way to reach this area of code should
 by by specifying a task.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/44240#comment:8>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list