[wp-trac] [WordPress Trac] #43986: Disable "Install Plugin" button for PHP required version mismatch

[WordPress Trac]

#43986: Disable "Install Plugin" button for PHP required version mismatch
-------------------------------------------------+-------------------------
 Reporter:  schlessera                           |       Owner:  (none)
     Type:  task (blessed)                       |      Status:  new
 Priority:  normal                               |   Milestone:  5.0
Component:  Plugins                              |     Version:
 Severity:  major                                |  Resolution:
 Keywords:  needs-unit-tests servehappy dev-     |     Focuses:
  feedback has-patch                             |
-------------------------------------------------+-------------------------

Comment (by joyously):

 > I agree that activation is actually the critical part with this.
 However, there is hardly a benefit of allowing the user to install an
 incompatible plugin, only to see one step later that it does not work.

 But there is a benefit: the user can prepare for the upgrade by installing
 what he needs first, then upgrading PHP, then activating the new plugins.
 Because after the upgrade, the warnings won't show him the plugins needed
 so easily. (Everything will look compatible, even the ones that he used to
 have which are not compatible.)

 > The current approach aims at highlighting that immediately, so that the
 user isn't required to perform unnecessary steps before getting to that
 conclusion.

 Don't you see that the user needs to install before the upgrade? WP
 doesn't know when that will be. I'm not suggesting that the user is not
 warned of the incompatibility. I'm suggesting that the user should be able
 to install, but not allowed to activate.

 > Preventing installation is also in line with preventing upgrades, which
 we will implement as well.

 I have the same concern there. The user should be able to update a plugin
 (seeing appropriate warnings), but not allowed to activate a mismatch. The
 logic for allowing should still be on activation, but different warnings
 would be shown for active or non-active plugins. I know this is on a
 different ticket, but I think it should all be handled in one place -
 activation.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/43986#comment:66>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform