[wp-trac] [WordPress Trac] #33735: Reduce Duplication and Improve Comment Notification Email Functions

[WordPress Trac]

#33735: Reduce Duplication and Improve Comment Notification Email Functions
----------------------------------------+-----------------------------
 Reporter:  dshanske                    |       Owner:  SergeyBiryukov
     Type:  enhancement                 |      Status:  reviewing
 Priority:  low                         |   Milestone:  5.0
Component:  Comments                    |     Version:
 Severity:  normal                      |  Resolution:
 Keywords:  has-patch needs-unit-tests  |     Focuses:
----------------------------------------+-----------------------------

Comment (by birgire):

 Thanks for the refresh @dshanske, that applies cleanly now.

 Regarding [attachment:33735.6.diff]:

 - As {{{get_comment_notify_text()}}} is for internal use, what about
 {{{_wp_get_comment_notify_text()}}} with the private {{{_}}} prefix?
 - There's a typo in {{{get_comment_notify_text()}}} with {{{$comment_id}}}
 instead of {{{$comment}}}.

 Some general remarks that comes to mind:

 - The {{{get_comment_notify_text()}}} function modifies some of the older
 strings.
 - Possible confusion between the existing filter
 {{{comment_notification_text}}} and the new filter
 {{{comment_notify_text}}}?
 - The new {{{comment_notify_text}}} filter applies to only part of the
 notify message
   and the {{{get_comment_notify_text()}}} function outputs part of the
 notify message.
   Would it be possible/suitable to have the function handle all of the
 notify message?


 Do you see these as a concern here? If so how could these be addressed?

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/33735#comment:30>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform