[wp-trac] [WordPress Trac] #44033: Get Avatar Comment Types should be a Function Not Just a Filter

WordPress Trac noreply at wordpress.org
Tue Jun 5 11:37:44 UTC 2018


#44033: Get Avatar  Comment Types should be a Function Not Just a Filter
--------------------------------------+---------------------
 Reporter:  dshanske                  |       Owner:  (none)
     Type:  enhancement               |      Status:  new
 Priority:  normal                    |   Milestone:  4.9.7
Component:  Comments                  |     Version:
 Severity:  normal                    |  Resolution:
 Keywords:  has-patch has-unit-tests  |     Focuses:
--------------------------------------+---------------------

Comment (by birgire):

 The patch [attachment:44033.3.diff] additionally:

 - Adjusts the {{{@return}}} description for the
 {{{is_avatar_comment_type()}}} function.
 - Adds the following tests cases for the {{{get_avatar_data()}}} function:
  -
 {{{Tests_Avatar::test_get_avatar_data_should_return_gravatar_url_when_input_avatar_comment_type()}}}
  -
 {{{Tests_Avatar::test_get_avatar_data_should_return_invalid_url_when_input_not_avatar_comment_type()}}}

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/44033#comment:8>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list