[wp-trac] [WordPress Trac] #44675: Media Trash action verbiage inconsistent and causes confusion

[WordPress Trac]

#44675: Media Trash action verbiage inconsistent and causes confusion
-----------------------------+-----------------------------
 Reporter:  garrett-eclipse  |      Owner:  (none)
     Type:  defect (bug)     |     Status:  new
 Priority:  normal           |  Milestone:  Awaiting Review
Component:  I18N             |    Version:  trunk
 Severity:  normal           |   Keywords:  good-first-bug
  Focuses:                   |
-----------------------------+-----------------------------
 Hello,

 While looking at the consistency for Bulk Actions I came across the Media
 list table uses 'MEDIA_TRASH' to enable it's trash functionality. It's
 trash action is labelled as 'Trash' with a context of 'verb' this is
 inconsistent with all other similar implementations of trash in the list
 tables as they all use 'Move to Trash' to remove the ambiguity. Aside from
 the consistency benefit we'll be able to remove the context as it's no
 longer needed to distinguish it from the Trash filter or page.

 So replacing this line;
 https://github.com/WordPress/WordPress/blob/8e01f9f99b9cc39bed623543f77752c819132699
 /wp-admin/includes/class-wp-media-list-table.php#L154

 With - `$actions['trash'] = __( 'Move to Trash' );`

 Will make it consistent with all other implementations;
 Comments list table -
 https://github.com/WordPress/WordPress/blob/1b5d6c6971c158e38b2f7c4ac6acfa19276aa5df
 /wp-admin/includes/class-wp-comments-list-table.php#L351
 Posts list table -
 https://github.com/WordPress/WordPress/blob/1b5d6c6971c158e38b2f7c4ac6acfa19276aa5df
 /wp-admin/includes/class-wp-posts-list-table.php#L413

 This will also clear up confusion for translators as it seemed my local
 en_CA was replacing Trash with Delete in this case which isn't correct;
 https://translate.wordpress.org/projects/wp/dev/en-
 ca/default?filters%5Bstatus%5D=either&filters%5Boriginal_id%5D=202108&filters%5Btranslation_id%5D=9657614
 *I'm cleaning up the translations.

 Thank you

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/44675>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform