[wp-trac] [WordPress Trac] #44674: Privacy Bulk Action 'Remove' should be 'Delete' or 'Move to Trash' to follow convention

[WordPress Trac]

#44674: Privacy Bulk Action 'Remove' should be 'Delete' or 'Move to Trash' to
follow convention
-----------------------------+-----------------------------
 Reporter:  garrett-eclipse  |      Owner:  (none)
     Type:  enhancement      |     Status:  new
 Priority:  normal           |  Milestone:  Awaiting Review
Component:  Privacy          |    Version:  4.9.6
 Severity:  normal           |   Keywords:  i18n-change
  Focuses:  privacy          |
-----------------------------+-----------------------------
 Hello,

 The Privacy tools utilize the verbiage 'Remove' for the delete action of
 removing requests which is unique aside from MS Users in the case where
 they remove from a site but aren't deleted. Reviewing other bulk actions
 on WP_List tables I found the convention is either 'Delete' if the content
 is removed by the action or 'Move to Trash' if it's archived.

 Looking at code this would only be a verbiage change as the underlying
 action is called 'delete';
 https://github.com/WordPress/WordPress/blob/b4320bcd8f9a4566c9c05ebdeaea0908079186f9
 /wp-admin/includes/user.php#L1152

 Other instances of similar bulk actions throughout WP;
 Links list table ('Delete') -
 https://github.com/WordPress/WordPress/blob/aaf99e691391cfceb004d848450dbbf3344b1bee
 /wp-admin/includes/class-wp-links-list-table.php#L86
 MS Sites list table ('Delete') -
 https://github.com/WordPress/WordPress/blob/99e3bb9077c5af8dcb421332be20e2f7558b9145
 /wp-admin/includes/class-wp-ms-sites-list-table.php#L204
 Users list table ('Delete' unless in MS it's 'Remove' as they're removing
 from site and not deleting from system) -
 https://github.com/WordPress/WordPress/blob/1b5d6c6971c158e38b2f7c4ac6acfa19276aa5df
 /wp-admin/includes/class-wp-users-list-table.php#L240
 Terms list table ('Delete') -
 https://github.com/WordPress/WordPress/blob/b76a714bba8c7373e443afab47d02d3d9df2aaa3
 /wp-admin/includes/class-wp-terms-list-table.php#L155
 - Comments list table ('Move to Trash' & 'Delete Permanently') -
 https://github.com/WordPress/WordPress/blob/1b5d6c6971c158e38b2f7c4ac6acfa19276aa5df
 /wp-admin/includes/class-wp-comments-list-table.php#L328
 - Plugins list table ('Delete') -
 https://github.com/WordPress/WordPress/blob/1b5d6c6971c158e38b2f7c4ac6acfa19276aa5df
 /wp-admin/includes/class-wp-plugins-list-table.php#L461
 - Posts list table ('Move to Trash' & 'Delete Permanently') -
 https://github.com/WordPress/WordPress/blob/1b5d6c6971c158e38b2f7c4ac6acfa19276aa5df
 /wp-admin/includes/class-wp-posts-list-table.php#L397
 - Media list table ('Delete Permanently', but if 'MEDIA_TRASH' enabled
 also has 'Trash' which I'm flagging in another ticket -
 https://github.com/WordPress/WordPress/blob/8e01f9f99b9cc39bed623543f77752c819132699
 /wp-admin/includes/class-wp-media-list-table.php#L147

 For the time being 'Delete' makes the most sense as it aligns with the
 other list tables when there's no trash archive. If #44222 is implemented
 to add an archive/trash state to the workflow then the convention would be
 'Move to Trash' and 'Delete Permanently' for the two actions depending if
 you're in the main view or archive/trash view.

 Thanks

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/44674>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform