[wp-trac] [WordPress Trac] #43749: Update zxcvbn to 4.4.2

WordPress Trac noreply at wordpress.org
Tue Jul 10 21:28:09 UTC 2018


#43749: Update zxcvbn to 4.4.2
-------------------------------------+-----------------------------
 Reporter:  desrosj                  |       Owner:  (none)
     Type:  enhancement              |      Status:  new
 Priority:  normal                   |   Milestone:  Future Release
Component:  External Libraries       |     Version:
 Severity:  normal                   |  Resolution:
 Keywords:  has-patch needs-testing  |     Focuses:  javascript
-------------------------------------+-----------------------------

Comment (by desrosj):

 Thanks for working on this, @omarreiss!

 It seems that the file is not being fully PGified. It does change the
 first set of dictionary words, but not the others (male names, female
 names, english Wikipedia, etc.). Also, if you edit a user and type a
 password into the field, it says "Password strength unknown". I am
 thinking this may just be from these other lists not being ciphered.

 Also, how do you feel about adding a new 822KB file to core? I am not sure
 it adds any benefit as it is just a handful of long dictionary strings.
 But, if we choose to keep it in the build, we should change the enqueue
 statement to remove `.min` when `SCRIPT_DEBUG` is enabled.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/43749#comment:11>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list