[wp-trac] [WordPress Trac] #43142: Do not warm term meta cache unnecessarily

WordPress Trac noreply at wordpress.org
Tue Jan 30 18:20:31 UTC 2018


#43142: Do not warm term meta cache unnecessarily
---------------------------+--------------------------
 Reporter:  peterwilsoncc  |       Owner:
     Type:  enhancement    |      Status:  new
 Priority:  normal         |   Milestone:  5.0
Component:  Taxonomy       |     Version:
 Severity:  normal         |  Resolution:
 Keywords:  has-patch      |     Focuses:  performance
---------------------------+--------------------------

Comment (by jrf):

 > You broke each argument for wp_get_object_terms() into its own line.
 This is not a strict violation of the coding standards, but I haven't seen
 this specific function use this formatting before. I changed it to what I
 see as the more common format. But maybe this could use advice from @jrf.
 (See right-hand 2460 in 43142.3.diff​ and 43142.2.diff​ )

 @boonebgorges Thanks for the ping. I've just had a quick look and the
 function layout in
 [https://core.trac.wordpress.org/attachment/ticket/43142/43142.2.diff
 43142.2.diff] is correct.

 The rules which come into play here are:
 1. For multi-item associative arrays, each array item should start on
 their own line.
 2. For multi-line function calls, each parameter should start on their own
 line.

 These rules have been correctly applied in the patch 2. In the patch 3,
 the second rule is disregarded.

 Hope this helps ;-)

--
Ticket URL: <https://core.trac.wordpress.org/ticket/43142#comment:6>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list