[wp-trac] [WordPress Trac] #17133: Code Editor: Register ctrl + s event for plugin/theme editor

WordPress Trac noreply at wordpress.org
Fri Jan 26 03:56:18 UTC 2018


#17133: Code Editor: Register ctrl + s event for plugin/theme editor
-------------------------------------------------+-------------------------
 Reporter:  jcnetsys                             |       Owner:
     Type:  enhancement                          |      Status:  new
 Priority:  high                                 |   Milestone:  Future
Component:  Plugins                              |  Release
 Severity:  normal                               |     Version:  3.1
 Keywords:  has-ux-feedback has-patch needs-     |  Resolution:
  testing                                        |     Focuses:
                                                 |  administration
-------------------------------------------------+-------------------------

Comment (by Junaidkbr):

 @westonruter Please review my patch and provide your feedback on it. I
 didn't know about this ticket but worked on the feature on my own. I was
 about to create a new ticket but found this one on my first search.

 Anyway, my patch is not modifying `code-editor.js` because this file is
 also used in '''Custom CSS''' editor. In `code-editor.js`, we don't have a
 context of which editor is this, or at least I didn't find any.

 There's another neat way to handle the document save with CodeMirror but I
 couldn't access the `commands` property anywhere. Ref:
 http://codemirror.net/doc/manual.html#commands

--
Ticket URL: <https://core.trac.wordpress.org/ticket/17133#comment:24>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list