[wp-trac] [WordPress Trac] #38332: "Cheating" message insults; needs changing

[WordPress Trac]

#38332: "Cheating" message insults; needs changing
--------------------------+-----------------------------
 Reporter:  ElectricFeet  |       Owner:
     Type:  enhancement   |      Status:  reopened
 Priority:  normal        |   Milestone:  4.9.3
Component:  General       |     Version:  2.9
 Severity:  normal        |  Resolution:
 Keywords:  has-patch     |     Focuses:  administration
--------------------------+-----------------------------

Comment (by peterwilsoncc):

 Thanks for the patch @dmsnell. If anyone helped you with in on the
 contributor day, could you please add their name to the ticket so they're
 sure to get props?

 In [attachment:38332.diff] I've built on the original patch a bit:

 * In most cases the error is known & detailed: `An error has occurred.`
 * Where permission is denied, I've switched the heading to `You
 don’t have access to this area.`
 * The generic nonce failure message is replaced with: `The link you
 followed has expired.`
 * I've removed changes to class names from the original patch, plugin
 authors may be relying on them so I don't want to break backward
 compatibility
 * For backward compatibility, I've kept cheatin as a property of
 `_wpCustomizeControlsL10n` even though it isn't used by core.

 Additional review of core messages sent to `wp_die()` shows the following
 as potentially insulting, or a little brief:

 * Slow down cowboy, no need to check for new mails so often!
 * Invalid post type.
 * Invalid taxonomy.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/38332#comment:22>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform