[wp-trac] [WordPress Trac] #43082: Add plugins search results: the plugin details modal opens in the thickbox modal

[WordPress Trac]

#43082: Add plugins search results: the plugin details modal opens in the thickbox
modal
-------------------------------------+-------------------------------------
 Reporter:  afercia                  |       Owner:  afercia
     Type:  defect (bug)             |      Status:  reopened
 Priority:  normal                   |   Milestone:  4.9.2
Component:  Plugins                  |     Version:  4.9
 Severity:  normal                   |  Resolution:
 Keywords:  has-screenshots has-     |     Focuses:  accessibility,
  patch fixed-major                  |  javascript
-------------------------------------+-------------------------------------
Changes (by afercia):

 * status:  closed => reopened
 * resolution:  fixed =>


Comment:

 As reported by @rinkuyadav999
 [https://wordpress.slack.com/archives/C02RQBWTW/p1516114373000152 on
 Slack] this broke the modal "Close" button. Quoting from the jQuery
 documentation:

 https://api.jquery.com/event.stoppropagation/
 > Since the .live() method handles events once they have propagated to the
 top of the document, it is not possible to stop propagation of live
 events. Similarly, events handled by .delegate() will propagate to the
 elements to which they are delegated; event handlers bound on any elements
 below it in the DOM tree will already have been executed by the time the
 delegated event handler is called. These handlers, therefore, may prevent
 the delegated handler from triggering by calling event.stopPropagation()
 or returning false.

 Thus, this event still needs to be delegated but preferably on the closest
 available ancestor, to avoid conflicts with other handlers.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/43082#comment:7>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform