[wp-trac] [WordPress Trac] #42643: FLV video format not playing

WordPress Trac noreply at wordpress.org
Sun Jan 14 15:06:42 UTC 2018


#42643: FLV video format not playing
--------------------------+-------------------------
 Reporter:  studiosx      |       Owner:  Clorith
     Type:  defect (bug)  |      Status:  assigned
 Priority:  normal        |   Milestone:  4.9.2
Component:  Media         |     Version:  4.9
 Severity:  normal        |  Resolution:
 Keywords:  has-patch     |     Focuses:  javascript
--------------------------+-------------------------

Comment (by birgire):

 ps: I tested


 {{{
 $grunt jshint:core --file=src/wp-includes/js/mediaelement/wp-
 mediaelement.js
 Running "jshint:core" (jshint) task

    src/wp-includes/js/mediaelement/wp-mediaelement.js
      65 |                    return '<a href="' + node.src + '">' +
 mejsL10n.strings["mejs.download-video"] + '</a>';
 ^ Strings must use singlequote.
      65 |                    return '<a href="' + node.src + '">' +
 mejsL10n.strings["mejs.download-video"] + '</a>';
                                                                     ^
 'mejsL10n' is not defined.

 >> 2 errors in 1 file
 Warning: Task "jshint:core" failed. Use --force to continue.

 Aborted due to warnings.

 }}}

 so it seems to prefer strings within single quotes.

 I'm not sure about the second error, since it works as a global on my
 install. But maybe it could be injected differently to silence jshint?

--
Ticket URL: <https://core.trac.wordpress.org/ticket/42643#comment:24>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list