[wp-trac] [WordPress Trac] #42643: FLV video format not playing

[WordPress Trac]

#42643: FLV video format not playing
--------------------------+-------------------------
 Reporter:  studiosx      |       Owner:  Clorith
     Type:  defect (bug)  |      Status:  assigned
 Priority:  normal        |   Milestone:  4.9.2
Component:  Media         |     Version:  4.9
 Severity:  normal        |  Resolution:
 Keywords:  has-patch     |     Focuses:  javascript
--------------------------+-------------------------

Comment (by birgire):

 1. ok I see, seems to be from this line: {{{e.ENABLE_ERROR &&
 (console.error ? console.error(i) : console.warn ? console.warn(i) :
 console.log(i))}}}
 2. yes it's probably better to use {{{indexOf()}}} here - if  maybe other
 formats need to be handled in the future, then one could reconsider.
 3. great
 4. nice

 I thought {{{mejs.download-video}}} would be used elsewhere, but I
 couldn't find other use cases. So I guess it's a good thing to use it then
 ;-)

 I'm not well versed in the [https://make.wordpress.org/core/handbook/best-
 practices/coding-standards/javascript/ javascript coding standard], so I
 wonder if either {{{mejsL10n.strings["mejs.download-video"]}}} or
 {{{mejsL10n.strings['mejs.download-video']}}} is preferred?

 [attachment:42643.4.patch] translates the string and looks otherwise good
 to me ;-)

--
Ticket URL: <https://core.trac.wordpress.org/ticket/42643#comment:23>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform