[wp-trac] [WordPress Trac] #43055: Reorganize Core JS / introduce build step

WordPress Trac noreply at wordpress.org
Fri Feb 16 08:22:21 UTC 2018


#43055: Reorganize Core JS / introduce build step
------------------------------+-------------------------
 Reporter:  omarreiss         |       Owner:
     Type:  enhancement       |      Status:  new
 Priority:  normal            |   Milestone:  5.0
Component:  Build/Test Tools  |     Version:  trunk
 Severity:  normal            |  Resolution:
 Keywords:  dev-feedback      |     Focuses:  javascript
------------------------------+-------------------------

Comment (by netweb):

 Replying to [comment:30 omarreiss]:
 > @netweb I have tried to leave updating dependencies out of scope for
 this patch. The versions in `package.json` are the versions that are in
 core right now, as far as I could verify.

 Great, I'll continue to update these as I've been doing recently and we
 can merge those changes here when needed

 > > Is the plan to use svn mv to move the src/index.php to src/_index.php
 >
 > That's absolutely a must have. Will put that on my todo list.

 Excellent, creating a list of each of these would be beneficial, maybe
 even separating the patch into two patches, one patch with changes, the
 other patch contains file moves where there are no changes, just
 renamed/moved.

 > > @omarreiss Would you prefer comments on the PR? I think that might be
 a little easier to manage feedback?
 >
 > That would be very helpful.

 Will do 👍🏼

 > PR for grunt-patch-wordpress has been opened here:
 https://github.com/WordPress/grunt-patch-wordpress/pull/54
 >
 > Will await review by @netweb, process feedback and include file mapping
 before I upload a 3rd patch.

 I had a quick look at that PR and is looking good, @jorbin has reviewed it
 and requested a few changes, I'll take another look after those changes
 are in.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/43055#comment:31>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list