[wp-trac] [WordPress Trac] #43232: User signups should be marked `active=0` after account is deleted

[WordPress Trac]

#43232: User signups should be marked `active=0` after account is deleted
--------------------------+-----------------------------
 Reporter:  boonebgorges  |      Owner:
     Type:  defect (bug)  |     Status:  new
 Priority:  normal        |  Milestone:  Awaiting Review
Component:  Users         |    Version:  3.0
 Severity:  normal        |   Keywords:  2nd-opinion
  Focuses:  multisite     |
--------------------------+-----------------------------
 On multisites with open registration, the flow works like this:

 1. User registers as wp-signup.php, which puts an entry into `wp_signups`
 with `active=0`.
 2. When the user clicks the link in the activation email, the `wp_users`
 entry is created, and the entry in `wp_signups` is marked `active=1`.

 Later, if that user's account is deleted - ie the record is removed from
 the `wp_users` table - the record in `wp_signups` is left untouched. This
 causes problems if the user creates an account, deletes it, and then tries
 to register again using the same login or email address.
 https://core.trac.wordpress.org/browser/tags/4.9.2/src/wp-includes/ms-
 functions.php?marks=503-524#L499

 The problem goes away after two days, after which registering with info
 that matches an existing signup causes the old signup to be deleted in
 favor of the new one.

 That said, it feels like some confusion could be avoided - and the
 database kept somewhat more internally consistent - by setting `active=0`
 when an account is deleted. Does this seem reasonable to others?

--
Ticket URL: <https://core.trac.wordpress.org/ticket/43232>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform